Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add consts that exercise circular imports #116

Closed
wants to merge 2 commits into from

Conversation

popham
Copy link
Contributor

@popham popham commented Dec 21, 2018

Demonstration of circular import issue from #113.

@codecov
Copy link

codecov bot commented Dec 21, 2018

Codecov Report

Merging #116 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #116   +/-   ##
=======================================
  Coverage   79.21%   79.21%           
=======================================
  Files          56       56           
  Lines        3560     3560           
  Branches      303      303           
=======================================
  Hits         2820     2820           
  Misses        650      650           
  Partials       90       90

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ace2ae...82def7d. Read the comment docs.

@jdiaz5513
Copy link
Owner

This should no longer be an issue as of 0.7.0. I have added your test cases in 97e871f.

@jdiaz5513 jdiaz5513 closed this Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants